From 46f308ed5e3c75492c0e28a46f9e9229c89d40f3 Mon Sep 17 00:00:00 2001 From: walon Date: Fri, 25 Apr 2025 22:02:54 +0800 Subject: [PATCH] [opt] optimization unnecessary initialization of typeArgsStack and methodArgsStack of GenericArgumentContext --- Editor/Meta/GenericArgumentContext.cs | 20 ++++---------------- 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/Editor/Meta/GenericArgumentContext.cs b/Editor/Meta/GenericArgumentContext.cs index ddff3d7..6aaab1c 100644 --- a/Editor/Meta/GenericArgumentContext.cs +++ b/Editor/Meta/GenericArgumentContext.cs @@ -7,13 +7,11 @@ using System.Threading.Tasks; namespace HybridCLR.Editor.Meta { - /// - /// Replaces generic type/method var with its generic argument - /// - public sealed class GenericArgumentContext + + public class GenericArgumentContext { - List typeArgsStack = new List(); - List methodArgsStack = new List(); + private readonly List typeArgsStack; + private readonly List methodArgsStack; public GenericArgumentContext(List typeArgsStack, List methodArgsStack) { @@ -21,16 +19,6 @@ namespace HybridCLR.Editor.Meta this.methodArgsStack = methodArgsStack; } - - - /// - /// Replaces a generic type/method var with its generic argument (if any). If - /// isn't a generic type/method var or if it can't - /// be resolved, it itself is returned. Else the resolved type is returned. - /// - /// Type signature - /// New which is never null unless - /// is null public TypeSig Resolve(TypeSig typeSig) { if (!typeSig.ContainsGenericParameter)