PHXH
/
unity-mcp
51
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: resolve Unknown pseudo class last-child USS warnings (#624) 

Unity UI Toolkit does not support the :last-child pseudo-class. Replace
it with a .section-last class that is applied programmatically to the
last section in each .section-stack container.

Also moves the Configure All Detected Clients button to the bottom
of the Client Configuration section and makes it auto-width.

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
main
dsarno 2026-01-25 11:45:48 -08:00 committed by GitHub
parent e00b2aed4f
commit 2eb26b85cf
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 31 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
MCPForUnity/Editor/Windows/Components/ClientConfig/McpClientConfigSection.uxml
View File

@ -7,7 +7,6 @@
<ui:Label text="Client:" class="setting-label" />
<ui:DropdownField name="client-dropdown" class="setting-dropdown-inline" />
</ui:VisualElement>
<ui:Button name="configure-all-button" text="Configure All Detected Clients" class="secondary-button" />
<ui:VisualElement class="setting-row">
<ui:VisualElement class="status-container">
<ui:VisualElement name="client-status-indicator" class="status-dot" />
@ -37,6 +36,7 @@
<ui:Label name="installation-steps" class="installation-steps" />
</ui:VisualElement>
</ui:Foldout>
<ui:Button name="configure-all-button" text="Configure All Detected Clients" class="secondary-button" style="width: auto; padding-left: 12px; padding-right: 12px;" />
</ui:VisualElement>
</ui:VisualElement>
</ui:UXML>

4
MCPForUnity/Editor/Windows/Components/Common.uss
View File

@ -26,7 +26,9 @@
}
/* Remove bottom margin from last section in a stack */
.section-stack > .section:last-child {
/* Note: Unity UI Toolkit doesn't support :last-child pseudo-class.
The .section-last class is applied programmatically instead. */
.section-stack > .section.section-last {
margin-bottom: 0px;
}

27
MCPForUnity/Editor/Windows/MCPForUnityEditorWindow.cs
View File

@ -278,6 +278,10 @@ namespace MCPForUnity.Editor.Windows
McpLog.Warn("Failed to load tools section UXML. Tool configuration will be unavailable.");
}
// Apply .section-last class to last section in each stack
// (Unity UI Toolkit doesn't support :last-child pseudo-class)
ApplySectionLastClasses();
guiCreated = true;
// Initial updates
@ -300,6 +304,29 @@ namespace MCPForUnity.Editor.Windows
toolsSection.Refresh();
}
/// <summary>
/// Applies the .section-last class to the last .section element in each .section-stack container.
/// This is a workaround for Unity UI Toolkit not supporting the :last-child pseudo-class.
/// </summary>
private void ApplySectionLastClasses()
{
var sectionStacks = rootVisualElement.Query<VisualElement>(className: "section-stack").ToList();
foreach (var stack in sectionStacks)
{
var sections = stack.Children().Where(c => c.ClassListContains("section")).ToList();
if (sections.Count > 0)
{
// Remove class from all sections first (in case of refresh)
foreach (var section in sections)
{
section.RemoveFromClassList("section-last");
}
// Add class to the last section
sections[sections.Count - 1].AddToClassList("section-last");
}
}
}
// Throttle OnEditorUpdate to avoid per-frame overhead (GitHub issue #577).
// Connection status polling every frame caused expensive network checks 60+ times/sec.
private double _lastEditorUpdateTime;