PHXH
/
unity-mcp
51
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

read_console: correct compiler diagnostic categorization (CSxxxx), preserve Debug.Log as Log without mode fallback, add explicit Debug.Log detection helper

main
David Sarno 2025-08-11 16:52:42 -07:00
parent 6439902d8d
commit 46f616df90
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
UnityMcpBridge/Editor/Tools/ReadConsole.cs
View File

@ -267,8 +267,8 @@ namespace UnityMcpBridge.Editor.Tools
// --- Filtering --- // --- Filtering ---
// Prefer classifying severity from message/stacktrace; fallback to mode bits if needed // Prefer classifying severity from message/stacktrace; fallback to mode bits if needed
LogType unityType = InferTypeFromMessage(message); LogType unityType = InferTypeFromMessage(message);
bool isExplicitDebugLog = IsExplicitDebugLog(message); bool isExplicitDebug = IsExplicitDebugLog(message);
if (!isExplicitDebugLog && unityType == LogType.Log) if (!isExplicitDebug && unityType == LogType.Log)
{ {
unityType = GetLogTypeFromMode(mode); unityType = GetLogTypeFromMode(mode);
} }
@ -423,10 +423,16 @@ namespace UnityMcpBridge.Editor.Tools
return LogType.Error; return LogType.Error;
if (fullMessage.IndexOf("LogWarning", StringComparison.OrdinalIgnoreCase) >= 0) if (fullMessage.IndexOf("LogWarning", StringComparison.OrdinalIgnoreCase) >= 0)
return LogType.Warning; return LogType.Warning;
if (IsExplicitDebugLog(fullMessage))
return LogType.Log;
// Exceptions often include the word "Exception" in the first lines // Compiler diagnostics (C#): "warning CSxxxx" / "error CSxxxx"
if (fullMessage.IndexOf(" warning CS", StringComparison.OrdinalIgnoreCase) >= 0
|| fullMessage.IndexOf(": warning CS", StringComparison.OrdinalIgnoreCase) >= 0)
return LogType.Warning;
if (fullMessage.IndexOf(" error CS", StringComparison.OrdinalIgnoreCase) >= 0
|| fullMessage.IndexOf(": error CS", StringComparison.OrdinalIgnoreCase) >= 0)
return LogType.Error;
// Exceptions (avoid misclassifying compiler diagnostics)
if (fullMessage.IndexOf("Exception", StringComparison.OrdinalIgnoreCase) >= 0) if (fullMessage.IndexOf("Exception", StringComparison.OrdinalIgnoreCase) >= 0)
return LogType.Exception; return LogType.Exception;
@ -439,7 +445,6 @@ namespace UnityMcpBridge.Editor.Tools
private static bool IsExplicitDebugLog(string fullMessage) private static bool IsExplicitDebugLog(string fullMessage)
{ {
// Detect explicit Debug.Log in the stacktrace/message to lock type to Log
if (string.IsNullOrEmpty(fullMessage)) return false; if (string.IsNullOrEmpty(fullMessage)) return false;
if (fullMessage.IndexOf("Debug:Log (", StringComparison.OrdinalIgnoreCase) >= 0) return true; if (fullMessage.IndexOf("Debug:Log (", StringComparison.OrdinalIgnoreCase) >= 0) return true;
if (fullMessage.IndexOf("UnityEngine.Debug:Log (", StringComparison.OrdinalIgnoreCase) >= 0) return true; if (fullMessage.IndexOf("UnityEngine.Debug:Log (", StringComparison.OrdinalIgnoreCase) >= 0) return true;