From 90911aa4d7c734aa84d53e7c49fa2b72305e4724 Mon Sep 17 00:00:00 2001 From: Marcus Sanatan Date: Fri, 17 Oct 2025 13:35:47 -0400 Subject: [PATCH] Use secure unity version (#321) * chore: update Unity version from 2021.3.45f1 to 2021.3.45f2 Older Unity version had the security vulnerability, so we update it * feat: add dynamic version display in editor window settings * refactor: remove manual license file handling from Unity test workflow * Revert "refactor: remove manual license file handling from Unity test workflow" This reverts commit a6ab3d982e792039c01a4afd353e61c7e22a2c3c. * feat: add Unity license credentials to Docker containers in CI workflow * refactor: replace manual Unity license activation with game-ci/unity-activator * refactor: simplify Unity CI setup by removing game-ci activation and using built-in license handling * fix: improve Unity license activation in CI by using unityci image's built-in activation flow * refactor: activate once in a temporary container, then reuse the license in the long-running container Now we got the license secret to be read, we got this error: "Machine bindings don't match". So it seems that the license I generated locally can't be used. So we need to activate the license within the container * Revert "refactor: activate once in a temporary container, then reuse the license in the long-running container" This reverts commit f6a9aa68f910df37cede6f83d535098be2a9f80b. * Revert "fix: improve Unity license activation in CI by using unityci image's built-in activation flow" This reverts commit a9f4c0223bc3467442be6dafa1d9303479623a7c. * Revert "refactor: simplify Unity CI setup by removing game-ci activation and using built-in license handling" This reverts commit 4e5ffc0051a7b15b9d87ecaa06fa646f8b13b0b9. * Revert "refactor: replace manual Unity license activation with game-ci/unity-activator" This reverts commit e9520ee768c4e9d48efc81b1a9c3cac3986cc96a. * Revert "feat: add Unity license credentials to Docker containers in CI workflow" This reverts commit 01b8879e35baaf88239988b51e6d4f1e5daaa1cf. --- .github/workflows/claude-nl-suite.yml | 2 +- .github/workflows/unity-tests.yml | 2 +- MCPForUnity/Editor/Windows/MCPForUnityEditorWindowNew.cs | 3 +++ MCPForUnity/Editor/Windows/MCPForUnityEditorWindowNew.uxml | 2 +- TestProjects/UnityMCPTests/ProjectSettings/ProjectVersion.txt | 4 ++-- 5 files changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/workflows/claude-nl-suite.yml b/.github/workflows/claude-nl-suite.yml index e5b8876..513dfb7 100644 --- a/.github/workflows/claude-nl-suite.yml +++ b/.github/workflows/claude-nl-suite.yml @@ -11,7 +11,7 @@ concurrency: cancel-in-progress: true env: - UNITY_IMAGE: unityci/editor:ubuntu-2021.3.45f1-linux-il2cpp-3 + UNITY_IMAGE: unityci/editor:ubuntu-2021.3.45f2-linux-il2cpp-3 jobs: nl-suite: diff --git a/.github/workflows/unity-tests.yml b/.github/workflows/unity-tests.yml index 4b795ad..8f0837b 100644 --- a/.github/workflows/unity-tests.yml +++ b/.github/workflows/unity-tests.yml @@ -20,7 +20,7 @@ jobs: testMode: - editmode unityVersion: - - 2021.3.45f1 + - 2021.3.45f2 steps: # Checkout - name: Checkout repository diff --git a/MCPForUnity/Editor/Windows/MCPForUnityEditorWindowNew.cs b/MCPForUnity/Editor/Windows/MCPForUnityEditorWindowNew.cs index 3987f11..39e8c15 100644 --- a/MCPForUnity/Editor/Windows/MCPForUnityEditorWindowNew.cs +++ b/MCPForUnity/Editor/Windows/MCPForUnityEditorWindowNew.cs @@ -24,6 +24,7 @@ namespace MCPForUnity.Editor.Windows } // Settings UI Elements + private Label versionLabel; private Toggle debugLogsToggle; private EnumField validationLevelField; private Label validationDescription; @@ -191,6 +192,7 @@ namespace MCPForUnity.Editor.Windows private void CacheUIElements() { // Settings + versionLabel = rootVisualElement.Q