PHXH
/
unity-mcp
51
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use secure unity version (#321) 

* chore: update Unity version from 2021.3.45f1 to 2021.3.45f2

Older Unity version had the security vulnerability, so we update it

* feat: add dynamic version display in editor window settings

* refactor: remove manual license file handling from Unity test workflow

* Revert "refactor: remove manual license file handling from Unity test workflow"

This reverts commit a6ab3d982e792039c01a4afd353e61c7e22a2c3c.

* feat: add Unity license credentials to Docker containers in CI workflow

* refactor: replace manual Unity license activation with game-ci/unity-activator

* refactor: simplify Unity CI setup by removing game-ci activation and using built-in license handling

* fix: improve Unity license activation in CI by using unityci image's built-in activation flow

* refactor:  activate once in a temporary container, then reuse the license in the long-running container

Now we got the license secret to be read, we got this error: "Machine bindings don't match". So it seems that the license I generated locally can't be used.

So we need to activate the license within the container

* Revert "refactor:  activate once in a temporary container, then reuse the license in the long-running container"

This reverts commit f6a9aa68f910df37cede6f83d535098be2a9f80b.

* Revert "fix: improve Unity license activation in CI by using unityci image's built-in activation flow"

This reverts commit a9f4c0223bc3467442be6dafa1d9303479623a7c.

* Revert "refactor: simplify Unity CI setup by removing game-ci activation and using built-in license handling"

This reverts commit 4e5ffc0051a7b15b9d87ecaa06fa646f8b13b0b9.

* Revert "refactor: replace manual Unity license activation with game-ci/unity-activator"

This reverts commit e9520ee768c4e9d48efc81b1a9c3cac3986cc96a.

* Revert "feat: add Unity license credentials to Docker containers in CI workflow"

This reverts commit 01b8879e35baaf88239988b51e6d4f1e5daaa1cf.
main
Marcus Sanatan 2025-10-17 13:35:47 -04:00 committed by GitHub
parent 6c00294231
commit 90911aa4d7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/claude-nl-suite.yml vendored
View File

@ -11,7 +11,7 @@ concurrency:
cancel-in-progress: true cancel-in-progress: true
env: env:
UNITY_IMAGE: unityci/editor:ubuntu-2021.3.45f1-linux-il2cpp-3 UNITY_IMAGE: unityci/editor:ubuntu-2021.3.45f2-linux-il2cpp-3
jobs: jobs:
nl-suite: nl-suite:

2
.github/workflows/unity-tests.yml vendored
View File

@ -20,7 +20,7 @@ jobs:
testMode: testMode:
- editmode - editmode
unityVersion: unityVersion:
- 2021.3.45f1 - 2021.3.45f2
steps: steps:
# Checkout # Checkout
- name: Checkout repository - name: Checkout repository

3
MCPForUnity/Editor/Windows/MCPForUnityEditorWindowNew.cs
View File

@ -24,6 +24,7 @@ namespace MCPForUnity.Editor.Windows
} }
// Settings UI Elements // Settings UI Elements
private Label versionLabel;
private Toggle debugLogsToggle; private Toggle debugLogsToggle;
private EnumField validationLevelField; private EnumField validationLevelField;
private Label validationDescription; private Label validationDescription;
@ -191,6 +192,7 @@ namespace MCPForUnity.Editor.Windows
private void CacheUIElements() private void CacheUIElements()
{ {
// Settings // Settings
versionLabel = rootVisualElement.Q<Label>("version-label");
debugLogsToggle = rootVisualElement.Q<Toggle>("debug-logs-toggle"); debugLogsToggle = rootVisualElement.Q<Toggle>("debug-logs-toggle");
validationLevelField = rootVisualElement.Q<EnumField>("validation-level"); validationLevelField = rootVisualElement.Q<EnumField>("validation-level");
validationDescription = rootVisualElement.Q<Label>("validation-description"); validationDescription = rootVisualElement.Q<Label>("validation-description");
@ -240,6 +242,7 @@ namespace MCPForUnity.Editor.Windows
private void InitializeUI() private void InitializeUI()
{ {
// Settings Section // Settings Section
versionLabel.text = AssetPathUtility.GetPackageVersion();
debugLogsToggle.value = EditorPrefs.GetBool("MCPForUnity.DebugLogs", false); debugLogsToggle.value = EditorPrefs.GetBool("MCPForUnity.DebugLogs", false);
validationLevelField.Init(ValidationLevel.Standard); validationLevelField.Init(ValidationLevel.Standard);

2
MCPForUnity/Editor/Windows/MCPForUnityEditorWindowNew.uxml
View File

@ -9,7 +9,7 @@
<ui:VisualElement class="section-content"> <ui:VisualElement class="section-content">
<ui:VisualElement class="setting-row"> <ui:VisualElement class="setting-row">
<ui:Label text="Version:" class="setting-label" /> <ui:Label text="Version:" class="setting-label" />
<ui:Label text="5.0.0" name="version-label" class="setting-value" /> <ui:Label text="..." name="version-label" class="setting-value" />
</ui:VisualElement> </ui:VisualElement>
<ui:VisualElement class="setting-row"> <ui:VisualElement class="setting-row">
<ui:Label text="Show Debug Logs:" class="setting-label" /> <ui:Label text="Show Debug Logs:" class="setting-label" />

4
TestProjects/UnityMCPTests/ProjectSettings/ProjectVersion.txt
View File

@ -1,2 +1,2 @@
m_EditorVersion: 2021.3.45f1 m_EditorVersion: 2021.3.45f2
m_EditorVersionWithRevision: 2021.3.45f1 (0da89fac8e79) m_EditorVersionWithRevision: 2021.3.45f2 (88f88f591b2e)