using System; using System.Collections.Generic; using System.IO; using System.Runtime.InteropServices; using MCPForUnity.Editor.Constants; using MCPForUnity.Editor.Helpers; using MCPForUnity.Editor.Models; using MCPForUnity.Editor.Services; using Newtonsoft.Json; using Newtonsoft.Json.Linq; using UnityEditor; using UnityEngine; namespace MCPForUnity.Editor.Clients { /// Shared base class for MCP configurators. public abstract class McpClientConfiguratorBase : IMcpClientConfigurator { protected readonly McpClient client; protected McpClientConfiguratorBase(McpClient client) { this.client = client; } internal McpClient Client => client; public string Id => client.name.Replace(" ", "").ToLowerInvariant(); public virtual string DisplayName => client.name; public McpStatus Status => client.status; public ConfiguredTransport ConfiguredTransport => client.configuredTransport; public virtual bool SupportsAutoConfigure => true; public virtual string GetConfigureActionLabel() => "Configure"; public abstract string GetConfigPath(); public abstract McpStatus CheckStatus(bool attemptAutoRewrite = true); public abstract void Configure(); public abstract string GetManualSnippet(); public abstract IList GetInstallationSteps(); protected string GetUvxPathOrError() { string uvx = MCPServiceLocator.Paths.GetUvxPath(); if (string.IsNullOrEmpty(uvx)) { throw new InvalidOperationException("uvx not found. Install uv/uvx or set the override in Advanced Settings."); } return uvx; } protected string CurrentOsPath() { if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows)) return client.windowsConfigPath; if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX)) return client.macConfigPath; return client.linuxConfigPath; } protected bool UrlsEqual(string a, string b) { if (string.IsNullOrWhiteSpace(a) || string.IsNullOrWhiteSpace(b)) { return false; } if (Uri.TryCreate(a.Trim(), UriKind.Absolute, out var uriA) && Uri.TryCreate(b.Trim(), UriKind.Absolute, out var uriB)) { return Uri.Compare( uriA, uriB, UriComponents.HttpRequestUrl, UriFormat.SafeUnescaped, StringComparison.OrdinalIgnoreCase) == 0; } string Normalize(string value) => value.Trim().TrimEnd('/'); return string.Equals(Normalize(a), Normalize(b), StringComparison.OrdinalIgnoreCase); } } /// JSON-file based configurator (Cursor, Windsurf, VS Code, etc.). public abstract class JsonFileMcpConfigurator : McpClientConfiguratorBase { public JsonFileMcpConfigurator(McpClient client) : base(client) { } public override string GetConfigPath() => CurrentOsPath(); public override McpStatus CheckStatus(bool attemptAutoRewrite = true) { try { string path = GetConfigPath(); if (!File.Exists(path)) { client.SetStatus(McpStatus.NotConfigured); client.configuredTransport = Models.ConfiguredTransport.Unknown; return client.status; } string configJson = File.ReadAllText(path); string[] args = null; string configuredUrl = null; bool configExists = false; if (client.IsVsCodeLayout) { var vsConfig = JsonConvert.DeserializeObject(configJson) as JObject; if (vsConfig != null) { var unityToken = vsConfig["servers"]?["unityMCP"] ?? vsConfig["mcp"]?["servers"]?["unityMCP"]; if (unityToken is JObject unityObj) { configExists = true; var argsToken = unityObj["args"]; if (argsToken is JArray) { args = argsToken.ToObject(); } var urlToken = unityObj["url"] ?? unityObj["serverUrl"]; if (urlToken != null && urlToken.Type != JTokenType.Null) { configuredUrl = urlToken.ToString(); } } } } else { McpConfig standardConfig = JsonConvert.DeserializeObject(configJson); if (standardConfig?.mcpServers?.unityMCP != null) { args = standardConfig.mcpServers.unityMCP.args; configuredUrl = standardConfig.mcpServers.unityMCP.url; configExists = true; } } if (!configExists) { client.SetStatus(McpStatus.MissingConfig); client.configuredTransport = Models.ConfiguredTransport.Unknown; return client.status; } // Determine and set the configured transport type if (args != null && args.Length > 0) { client.configuredTransport = Models.ConfiguredTransport.Stdio; } else if (!string.IsNullOrEmpty(configuredUrl)) { // Distinguish HTTP Local from HTTP Remote by matching against both URLs string localRpcUrl = HttpEndpointUtility.GetLocalMcpRpcUrl(); string remoteRpcUrl = HttpEndpointUtility.GetRemoteMcpRpcUrl(); if (!string.IsNullOrEmpty(remoteRpcUrl) && UrlsEqual(configuredUrl, remoteRpcUrl)) { client.configuredTransport = Models.ConfiguredTransport.HttpRemote; } else { client.configuredTransport = Models.ConfiguredTransport.Http; } } else { client.configuredTransport = Models.ConfiguredTransport.Unknown; } bool matches = false; if (args != null && args.Length > 0) { string expectedUvxUrl = AssetPathUtility.GetMcpServerPackageSource(); string configuredUvxUrl = McpConfigurationHelper.ExtractUvxUrl(args); matches = !string.IsNullOrEmpty(configuredUvxUrl) && McpConfigurationHelper.PathsEqual(configuredUvxUrl, expectedUvxUrl); } else if (!string.IsNullOrEmpty(configuredUrl)) { // Match against the active scope's URL string expectedUrl = HttpEndpointUtility.GetMcpRpcUrl(); matches = UrlsEqual(configuredUrl, expectedUrl); } if (matches) { client.SetStatus(McpStatus.Configured); return client.status; } if (attemptAutoRewrite) { var result = McpConfigurationHelper.WriteMcpConfiguration(path, client); if (result == "Configured successfully") { client.SetStatus(McpStatus.Configured); client.configuredTransport = HttpEndpointUtility.GetCurrentServerTransport(); } else { client.SetStatus(McpStatus.IncorrectPath); } } else { client.SetStatus(McpStatus.IncorrectPath); } } catch (Exception ex) { client.SetStatus(McpStatus.Error, ex.Message); client.configuredTransport = Models.ConfiguredTransport.Unknown; } return client.status; } public override void Configure() { string path = GetConfigPath(); McpConfigurationHelper.EnsureConfigDirectoryExists(path); string result = McpConfigurationHelper.WriteMcpConfiguration(path, client); if (result == "Configured successfully") { client.SetStatus(McpStatus.Configured); client.configuredTransport = HttpEndpointUtility.GetCurrentServerTransport(); } else { throw new InvalidOperationException(result); } } public override string GetManualSnippet() { try { string uvx = GetUvxPathOrError(); return ConfigJsonBuilder.BuildManualConfigJson(uvx, client); } catch (Exception ex) { var errorObj = new { error = ex.Message }; return JsonConvert.SerializeObject(errorObj); } } public override IList GetInstallationSteps() => new List { "Configuration steps not available for this client." }; } /// Codex (TOML) configurator. public abstract class CodexMcpConfigurator : McpClientConfiguratorBase { public CodexMcpConfigurator(McpClient client) : base(client) { } public override string GetConfigPath() => CurrentOsPath(); public override McpStatus CheckStatus(bool attemptAutoRewrite = true) { try { string path = GetConfigPath(); if (!File.Exists(path)) { client.SetStatus(McpStatus.NotConfigured); client.configuredTransport = Models.ConfiguredTransport.Unknown; return client.status; } string toml = File.ReadAllText(path); if (CodexConfigHelper.TryParseCodexServer(toml, out _, out var args, out var url)) { // Determine and set the configured transport type if (!string.IsNullOrEmpty(url)) { // Distinguish HTTP Local from HTTP Remote string remoteRpcUrl = HttpEndpointUtility.GetRemoteMcpRpcUrl(); if (!string.IsNullOrEmpty(remoteRpcUrl) && UrlsEqual(url, remoteRpcUrl)) { client.configuredTransport = Models.ConfiguredTransport.HttpRemote; } else { client.configuredTransport = Models.ConfiguredTransport.Http; } } else if (args != null && args.Length > 0) { client.configuredTransport = Models.ConfiguredTransport.Stdio; } else { client.configuredTransport = Models.ConfiguredTransport.Unknown; } bool matches = false; if (!string.IsNullOrEmpty(url)) { // Match against the active scope's URL matches = UrlsEqual(url, HttpEndpointUtility.GetMcpRpcUrl()); } else if (args != null && args.Length > 0) { string expected = AssetPathUtility.GetMcpServerPackageSource(); string configured = McpConfigurationHelper.ExtractUvxUrl(args); matches = !string.IsNullOrEmpty(configured) && McpConfigurationHelper.PathsEqual(configured, expected); } if (matches) { client.SetStatus(McpStatus.Configured); return client.status; } } else { client.configuredTransport = Models.ConfiguredTransport.Unknown; } if (attemptAutoRewrite) { string result = McpConfigurationHelper.ConfigureCodexClient(path, client); if (result == "Configured successfully") { client.SetStatus(McpStatus.Configured); client.configuredTransport = HttpEndpointUtility.GetCurrentServerTransport(); } else { client.SetStatus(McpStatus.IncorrectPath); } } else { client.SetStatus(McpStatus.IncorrectPath); } } catch (Exception ex) { client.SetStatus(McpStatus.Error, ex.Message); client.configuredTransport = Models.ConfiguredTransport.Unknown; } return client.status; } public override void Configure() { string path = GetConfigPath(); McpConfigurationHelper.EnsureConfigDirectoryExists(path); string result = McpConfigurationHelper.ConfigureCodexClient(path, client); if (result == "Configured successfully") { client.SetStatus(McpStatus.Configured); client.configuredTransport = HttpEndpointUtility.GetCurrentServerTransport(); } else { throw new InvalidOperationException(result); } } public override string GetManualSnippet() { try { string uvx = GetUvxPathOrError(); return CodexConfigHelper.BuildCodexServerBlock(uvx); } catch (Exception ex) { return $"# error: {ex.Message}"; } } public override IList GetInstallationSteps() => new List { "Run 'codex config edit' or open the config path", "Paste the TOML", "Save and restart Codex" }; } /// CLI-based configurator (Claude Code). public abstract class ClaudeCliMcpConfigurator : McpClientConfiguratorBase { public ClaudeCliMcpConfigurator(McpClient client) : base(client) { } public override bool SupportsAutoConfigure => true; public override string GetConfigureActionLabel() => client.status == McpStatus.Configured ? "Unregister" : "Register"; public override string GetConfigPath() => "Managed via Claude CLI"; /// /// Checks the Claude CLI registration status. /// MUST be called from the main Unity thread due to EditorPrefs and Application.dataPath access. /// public override McpStatus CheckStatus(bool attemptAutoRewrite = true) { // Capture main-thread-only values before delegating to thread-safe method string projectDir = Path.GetDirectoryName(Application.dataPath); bool useHttpTransport = EditorConfigurationCache.Instance.UseHttpTransport; // Resolve claudePath on the main thread (EditorPrefs access) string claudePath = MCPServiceLocator.Paths.GetClaudeCliPath(); RuntimePlatform platform = Application.platform; bool isRemoteScope = HttpEndpointUtility.IsRemoteScope(); string expectedPackageSource = AssetPathUtility.GetMcpServerPackageSource(); return CheckStatusWithProjectDir(projectDir, useHttpTransport, claudePath, platform, isRemoteScope, expectedPackageSource, attemptAutoRewrite); } /// /// Internal thread-safe version of CheckStatus. /// Can be called from background threads because all main-thread-only values are passed as parameters. /// projectDir, useHttpTransport, claudePath, platform, isRemoteScope, and expectedPackageSource are REQUIRED /// (non-nullable where applicable) to enforce thread safety at compile time. /// NOTE: attemptAutoRewrite is NOT fully thread-safe because Configure() requires the main thread. /// When called from a background thread, pass attemptAutoRewrite=false and handle re-registration /// on the main thread based on the returned status. /// internal McpStatus CheckStatusWithProjectDir( string projectDir, bool useHttpTransport, string claudePath, RuntimePlatform platform, bool isRemoteScope, string expectedPackageSource, bool attemptAutoRewrite = false) { try { if (string.IsNullOrEmpty(claudePath)) { client.SetStatus(McpStatus.NotConfigured, "Claude CLI not found"); client.configuredTransport = Models.ConfiguredTransport.Unknown; return client.status; } // projectDir is required - no fallback to Application.dataPath if (string.IsNullOrEmpty(projectDir)) { throw new ArgumentNullException(nameof(projectDir), "Project directory must be provided for thread-safe execution"); } string pathPrepend = null; if (platform == RuntimePlatform.OSXEditor) { pathPrepend = "/opt/homebrew/bin:/usr/local/bin:/usr/bin:/bin"; } else if (platform == RuntimePlatform.LinuxEditor) { pathPrepend = "/usr/local/bin:/usr/bin:/bin"; } try { string claudeDir = Path.GetDirectoryName(claudePath); if (!string.IsNullOrEmpty(claudeDir)) { pathPrepend = string.IsNullOrEmpty(pathPrepend) ? claudeDir : $"{claudeDir}:{pathPrepend}"; } } catch { } // Check if UnityMCP exists (handles both "UnityMCP" and legacy "unityMCP") if (ExecPath.TryRun(claudePath, "mcp list", projectDir, out var listStdout, out var listStderr, 10000, pathPrepend)) { if (!string.IsNullOrEmpty(listStdout) && listStdout.IndexOf("UnityMCP", StringComparison.OrdinalIgnoreCase) >= 0) { // UnityMCP is registered - now verify transport mode matches // useHttpTransport parameter is required (non-nullable) to ensure thread safety bool currentUseHttp = useHttpTransport; // Get detailed info about the registration to check transport type // Try both "UnityMCP" and "unityMCP" (legacy naming) string getStdout = null, getStderr = null; bool gotInfo = ExecPath.TryRun(claudePath, "mcp get UnityMCP", projectDir, out getStdout, out getStderr, 7000, pathPrepend) || ExecPath.TryRun(claudePath, "mcp get unityMCP", projectDir, out getStdout, out getStderr, 7000, pathPrepend); if (gotInfo) { // Parse the output to determine registered transport mode // The CLI output format contains "Type: http" or "Type: stdio" bool registeredWithHttp = getStdout.Contains("Type: http", StringComparison.OrdinalIgnoreCase); bool registeredWithStdio = getStdout.Contains("Type: stdio", StringComparison.OrdinalIgnoreCase); // Set the configured transport based on what we detected // For HTTP, we can't distinguish local/remote from CLI output alone, // so infer from the current scope setting when HTTP is detected. if (registeredWithHttp) { client.configuredTransport = isRemoteScope ? Models.ConfiguredTransport.HttpRemote : Models.ConfiguredTransport.Http; } else if (registeredWithStdio) { client.configuredTransport = Models.ConfiguredTransport.Stdio; } else { client.configuredTransport = Models.ConfiguredTransport.Unknown; } // Check for transport mismatch (3-way: Stdio, Http, HttpRemote) bool hasTransportMismatch = (currentUseHttp && registeredWithStdio) || (!currentUseHttp && registeredWithHttp); // For stdio transport, also check package version bool hasVersionMismatch = false; string configuredPackageSource = null; if (registeredWithStdio) { // expectedPackageSource was captured on main thread and passed as parameter configuredPackageSource = ExtractPackageSourceFromCliOutput(getStdout); hasVersionMismatch = !string.IsNullOrEmpty(configuredPackageSource) && !string.Equals(configuredPackageSource, expectedPackageSource, StringComparison.OrdinalIgnoreCase); } // If there's any mismatch and auto-rewrite is enabled, re-register if (hasTransportMismatch || hasVersionMismatch) { // Configure() requires main thread (accesses EditorPrefs, Application.dataPath) // Only attempt auto-rewrite if we're on the main thread bool isMainThread = System.Threading.Thread.CurrentThread.ManagedThreadId == 1; if (attemptAutoRewrite && isMainThread) { string reason = hasTransportMismatch ? $"Transport mismatch (registered: {(registeredWithHttp ? "HTTP" : "stdio")}, expected: {(currentUseHttp ? "HTTP" : "stdio")})" : $"Package version mismatch (registered: {configuredPackageSource}, expected: {expectedPackageSource})"; McpLog.Info($"{reason}. Re-registering..."); try { // Force re-register by ensuring status is not Configured (which would toggle to Unregister) client.SetStatus(McpStatus.IncorrectPath); Configure(); return client.status; } catch (Exception ex) { McpLog.Warn($"Auto-reregister failed: {ex.Message}"); client.SetStatus(McpStatus.IncorrectPath, $"Configuration mismatch. Click Configure to re-register."); return client.status; } } else { if (hasTransportMismatch) { string errorMsg = $"Transport mismatch: Claude Code is registered with {(registeredWithHttp ? "HTTP" : "stdio")} but current setting is {(currentUseHttp ? "HTTP" : "stdio")}. Click Configure to re-register."; client.SetStatus(McpStatus.Error, errorMsg); McpLog.Warn(errorMsg); } else { client.SetStatus(McpStatus.IncorrectPath, $"Package version mismatch: registered with '{configuredPackageSource}' but current version is '{expectedPackageSource}'."); } return client.status; } } } client.SetStatus(McpStatus.Configured); return client.status; } } client.SetStatus(McpStatus.NotConfigured); client.configuredTransport = Models.ConfiguredTransport.Unknown; } catch (Exception ex) { McpLog.Warn($"[Claude Code] CheckStatus exception: {ex.GetType().Name}: {ex.Message}"); client.SetStatus(McpStatus.Error, ex.Message); client.configuredTransport = Models.ConfiguredTransport.Unknown; } return client.status; } public override void Configure() { if (client.status == McpStatus.Configured) { Unregister(); } else { Register(); } } /// /// Thread-safe version of Configure that uses pre-captured main-thread values. /// All parameters must be captured on the main thread before calling this method. /// public void ConfigureWithCapturedValues( string projectDir, string claudePath, string pathPrepend, bool useHttpTransport, string httpUrl, string uvxPath, string gitUrl, string packageName, bool shouldForceRefresh, string apiKey, Models.ConfiguredTransport serverTransport) { if (client.status == McpStatus.Configured) { UnregisterWithCapturedValues(projectDir, claudePath, pathPrepend); } else { RegisterWithCapturedValues(projectDir, claudePath, pathPrepend, useHttpTransport, httpUrl, uvxPath, gitUrl, packageName, shouldForceRefresh, apiKey, serverTransport); } } /// /// Thread-safe registration using pre-captured values. /// private void RegisterWithCapturedValues( string projectDir, string claudePath, string pathPrepend, bool useHttpTransport, string httpUrl, string uvxPath, string gitUrl, string packageName, bool shouldForceRefresh, string apiKey, Models.ConfiguredTransport serverTransport) { if (string.IsNullOrEmpty(claudePath)) { throw new InvalidOperationException("Claude CLI not found. Please install Claude Code first."); } string args; if (useHttpTransport) { // Only include API key header for remote-hosted mode // Use --scope local to register in the project-local config, avoiding conflicts with user-level config (#664) if (serverTransport == Models.ConfiguredTransport.HttpRemote && !string.IsNullOrEmpty(apiKey)) { string safeKey = SanitizeShellHeaderValue(apiKey); args = $"mcp add --scope local --transport http UnityMCP {httpUrl} --header \"{AuthConstants.ApiKeyHeader}: {safeKey}\""; } else { args = $"mcp add --scope local --transport http UnityMCP {httpUrl}"; } } else { // Note: --reinstall is not supported by uvx, use --no-cache --refresh instead string devFlags = shouldForceRefresh ? "--no-cache --refresh " : string.Empty; // Use --scope local to register in the project-local config, avoiding conflicts with user-level config (#664) args = $"mcp add --scope local --transport stdio UnityMCP -- \"{uvxPath}\" {devFlags}--from \"{gitUrl}\" {packageName}"; } // Remove any existing registrations from ALL scopes to prevent stale config conflicts (#664) McpLog.Info("Removing any existing UnityMCP registrations from all scopes before adding..."); RemoveFromAllScopes(claudePath, projectDir, pathPrepend); // Now add the registration if (!ExecPath.TryRun(claudePath, args, projectDir, out var stdout, out var stderr, 15000, pathPrepend)) { throw new InvalidOperationException($"Failed to register with Claude Code:\n{stderr}\n{stdout}"); } McpLog.Info($"Successfully registered with Claude Code using {(useHttpTransport ? "HTTP" : "stdio")} transport."); client.SetStatus(McpStatus.Configured); client.configuredTransport = serverTransport; } /// /// Thread-safe unregistration using pre-captured values. /// private void UnregisterWithCapturedValues(string projectDir, string claudePath, string pathPrepend) { if (string.IsNullOrEmpty(claudePath)) { throw new InvalidOperationException("Claude CLI not found. Please install Claude Code first."); } // Remove from ALL scopes to ensure complete cleanup (#664) McpLog.Info("Removing all UnityMCP registrations from all scopes..."); RemoveFromAllScopes(claudePath, projectDir, pathPrepend); McpLog.Info("MCP server successfully unregistered from Claude Code."); client.SetStatus(McpStatus.NotConfigured); client.configuredTransport = Models.ConfiguredTransport.Unknown; } private void Register() { var pathService = MCPServiceLocator.Paths; string claudePath = pathService.GetClaudeCliPath(); if (string.IsNullOrEmpty(claudePath)) { throw new InvalidOperationException("Claude CLI not found. Please install Claude Code first."); } bool useHttpTransport = EditorConfigurationCache.Instance.UseHttpTransport; string args; if (useHttpTransport) { string httpUrl = HttpEndpointUtility.GetMcpRpcUrl(); // Only include API key header for remote-hosted mode // Use --scope local to register in the project-local config, avoiding conflicts with user-level config (#664) if (HttpEndpointUtility.IsRemoteScope()) { string apiKey = EditorPrefs.GetString(EditorPrefKeys.ApiKey, string.Empty); if (!string.IsNullOrEmpty(apiKey)) { string safeKey = SanitizeShellHeaderValue(apiKey); args = $"mcp add --scope local --transport http UnityMCP {httpUrl} --header \"{AuthConstants.ApiKeyHeader}: {safeKey}\""; } else { args = $"mcp add --scope local --transport http UnityMCP {httpUrl}"; } } else { args = $"mcp add --scope local --transport http UnityMCP {httpUrl}"; } } else { var (uvxPath, gitUrl, packageName) = AssetPathUtility.GetUvxCommandParts(); // Use central helper that checks both DevModeForceServerRefresh AND local path detection. // Note: --reinstall is not supported by uvx, use --no-cache --refresh instead string devFlags = AssetPathUtility.ShouldForceUvxRefresh() ? "--no-cache --refresh " : string.Empty; // Use --scope local to register in the project-local config, avoiding conflicts with user-level config (#664) args = $"mcp add --scope local --transport stdio UnityMCP -- \"{uvxPath}\" {devFlags}--from \"{gitUrl}\" {packageName}"; } string projectDir = Path.GetDirectoryName(Application.dataPath); string pathPrepend = null; if (Application.platform == RuntimePlatform.OSXEditor) { pathPrepend = "/opt/homebrew/bin:/usr/local/bin:/usr/bin:/bin"; } else if (Application.platform == RuntimePlatform.LinuxEditor) { pathPrepend = "/usr/local/bin:/usr/bin:/bin"; } try { string claudeDir = Path.GetDirectoryName(claudePath); if (!string.IsNullOrEmpty(claudeDir)) { pathPrepend = string.IsNullOrEmpty(pathPrepend) ? claudeDir : $"{claudeDir}:{pathPrepend}"; } } catch { } // Remove any existing registrations from ALL scopes to prevent stale config conflicts (#664) McpLog.Info("Removing any existing UnityMCP registrations from all scopes before adding..."); RemoveFromAllScopes(claudePath, projectDir, pathPrepend); // Now add the registration with the current transport mode if (!ExecPath.TryRun(claudePath, args, projectDir, out var stdout, out var stderr, 15000, pathPrepend)) { throw new InvalidOperationException($"Failed to register with Claude Code:\n{stderr}\n{stdout}"); } McpLog.Info($"Successfully registered with Claude Code using {(useHttpTransport ? "HTTP" : "stdio")} transport."); // Set status to Configured immediately after successful registration // The UI will trigger an async verification check separately to avoid blocking client.SetStatus(McpStatus.Configured); client.configuredTransport = HttpEndpointUtility.GetCurrentServerTransport(); } private void Unregister() { var pathService = MCPServiceLocator.Paths; string claudePath = pathService.GetClaudeCliPath(); if (string.IsNullOrEmpty(claudePath)) { throw new InvalidOperationException("Claude CLI not found. Please install Claude Code first."); } string projectDir = Path.GetDirectoryName(Application.dataPath); string pathPrepend = null; if (Application.platform == RuntimePlatform.OSXEditor) { pathPrepend = "/opt/homebrew/bin:/usr/local/bin:/usr/bin:/bin"; } else if (Application.platform == RuntimePlatform.LinuxEditor) { pathPrepend = "/usr/local/bin:/usr/bin:/bin"; } // Remove from ALL scopes to ensure complete cleanup (#664) McpLog.Info("Removing all UnityMCP registrations from all scopes..."); RemoveFromAllScopes(claudePath, projectDir, pathPrepend); McpLog.Info("MCP server successfully unregistered from Claude Code."); client.SetStatus(McpStatus.NotConfigured); client.configuredTransport = Models.ConfiguredTransport.Unknown; } public override string GetManualSnippet() { string uvxPath = MCPServiceLocator.Paths.GetUvxPath(); bool useHttpTransport = EditorConfigurationCache.Instance.UseHttpTransport; if (useHttpTransport) { string httpUrl = HttpEndpointUtility.GetMcpRpcUrl(); // Only include API key header for remote-hosted mode string headerArg = ""; if (HttpEndpointUtility.IsRemoteScope()) { string apiKey = EditorPrefs.GetString(EditorPrefKeys.ApiKey, string.Empty); headerArg = !string.IsNullOrEmpty(apiKey) ? $" --header \"{AuthConstants.ApiKeyHeader}: {SanitizeShellHeaderValue(apiKey)}\"" : ""; } return "# Register the MCP server with Claude Code:\n" + $"claude mcp add --scope local --transport http UnityMCP {httpUrl}{headerArg}\n\n" + "# Unregister the MCP server (from all scopes to clean up any stale configs):\n" + "claude mcp remove --scope local UnityMCP\n" + "claude mcp remove --scope user UnityMCP\n" + "claude mcp remove --scope project UnityMCP\n\n" + "# List registered servers:\n" + "claude mcp list"; } if (string.IsNullOrEmpty(uvxPath)) { return "# Error: Configuration not available - check paths in Advanced Settings"; } string packageSource = AssetPathUtility.GetMcpServerPackageSource(); // Use central helper that checks both DevModeForceServerRefresh AND local path detection. // Note: --reinstall is not supported by uvx, use --no-cache --refresh instead string devFlags = AssetPathUtility.ShouldForceUvxRefresh() ? "--no-cache --refresh " : string.Empty; return "# Register the MCP server with Claude Code:\n" + $"claude mcp add --scope local --transport stdio UnityMCP -- \"{uvxPath}\" {devFlags}--from \"{packageSource}\" mcp-for-unity\n\n" + "# Unregister the MCP server (from all scopes to clean up any stale configs):\n" + "claude mcp remove --scope local UnityMCP\n" + "claude mcp remove --scope user UnityMCP\n" + "claude mcp remove --scope project UnityMCP\n\n" + "# List registered servers:\n" + "claude mcp list"; } public override IList GetInstallationSteps() => new List { "Ensure Claude CLI is installed", "Use Register to add UnityMCP (or run claude mcp add UnityMCP)", "Restart Claude Code" }; /// /// Removes UnityMCP registration from all Claude Code configuration scopes (local, user, project). /// This ensures no stale or conflicting configurations remain across different scopes. /// Also handles legacy "unityMCP" naming convention. /// private static void RemoveFromAllScopes(string claudePath, string projectDir, string pathPrepend) { // Remove from all three scopes to prevent stale configs causing connection issues. // See GitHub issue #664 - conflicting configs at different scopes can cause // Claude Code to connect with outdated/incorrect configuration. string[] scopes = { "local", "user", "project" }; string[] names = { "UnityMCP", "unityMCP" }; // Include legacy naming foreach (var scope in scopes) { foreach (var name in names) { ExecPath.TryRun(claudePath, $"mcp remove --scope {scope} {name}", projectDir, out _, out _, 5000, pathPrepend); } } } /// /// Sanitizes a value for safe inclusion inside a double-quoted shell argument. /// Escapes characters that are special within double quotes (", \, `, $, !) /// to prevent shell injection or argument splitting. /// private static string SanitizeShellHeaderValue(string value) { if (string.IsNullOrEmpty(value)) return value; var sb = new System.Text.StringBuilder(value.Length); foreach (char c in value) { switch (c) { case '"': case '\\': case '`': case '$': case '!': sb.Append('\\'); sb.Append(c); break; default: sb.Append(c); break; } } return sb.ToString(); } /// /// Extracts the package source (--from argument value) from claude mcp get output. /// The output format includes args like: --from "mcpforunityserver==9.0.1" /// private static string ExtractPackageSourceFromCliOutput(string cliOutput) { if (string.IsNullOrEmpty(cliOutput)) return null; // Look for --from followed by the package source // The CLI output may have it quoted or unquoted int fromIndex = cliOutput.IndexOf("--from", StringComparison.OrdinalIgnoreCase); if (fromIndex < 0) return null; // Move past "--from" and any whitespace int startIndex = fromIndex + 6; while (startIndex < cliOutput.Length && char.IsWhiteSpace(cliOutput[startIndex])) startIndex++; if (startIndex >= cliOutput.Length) return null; // Check if value is quoted char quoteChar = cliOutput[startIndex]; if (quoteChar == '"' || quoteChar == '\'') { startIndex++; int endIndex = cliOutput.IndexOf(quoteChar, startIndex); if (endIndex > startIndex) return cliOutput.Substring(startIndex, endIndex - startIndex); } else { // Unquoted - read until whitespace or end of line int endIndex = startIndex; while (endIndex < cliOutput.Length && !char.IsWhiteSpace(cliOutput[endIndex])) endIndex++; if (endIndex > startIndex) return cliOutput.Substring(startIndex, endIndex - startIndex); } return null; } } }